Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error on a duplicate copy, expand website #2204

Merged
merged 3 commits into from
Aug 21, 2019
Merged

Throw an error on a duplicate copy, expand website #2204

merged 3 commits into from
Aug 21, 2019

Conversation

rileykarson
Copy link
Member

Followup to #2199, we detected duplicate compiled but not copied files previously. This will need to rebase off that PR to succeed.

Release Note for Downstream PRs (will be copied)

@rileykarson rileykarson requested a review from danawillow August 16, 2019 21:13
@rileykarson rileykarson mentioned this pull request Aug 16, 2019
Merged
@rileykarson rileykarson force-pushed the error-on-duplicate-copy branch from ea7ef9d to 9a61394 Compare August 19, 2019 18:32
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 9a61394.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1068
depends: hashicorp/terraform-provider-google#4294

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9a61394.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow
danawillow approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think hashicorp/terraform-provider-google#4294 also needs to be closed (or like, a new MM run to auto-close it or something)

@rileykarson
Copy link
Member Author

Yep- after hitting bad Magician timing twice I figured I would just close that one by hand.

@modular-magician modular-magician force-pushed the error-on-duplicate-copy branch from 9a61394 to 1152f65 Compare August 21, 2019 16:16
@modular-magician modular-magician merged commit 89efeeb into GoogleCloudPlatform:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileykarson @modular-magician @danawillow @googlebot